feat(userlib): Bump Motoko and support principal type in userlib by chenyan-dfinity · Pull Request #433 · dfinity/sdk

chenyan-dfinity · 2020-03-06T22:11:47Z

Bump motoko
Name change: Unit --> Null
Principal types in JS

git log --oneline --first-parent 788395608cdf75ecdff3c904bef52f2478467d5f..849cfba0b8dead6c6e5de0905491f9e33631eb32 src stdlib rts | cat
849cfba0 Fix for unsorted recorded fields after pattern inference (#1278)
44362755 update rts to decode principal (#1273)
8cccfe28 fix bug in mo_to_idl (#1275)
a856438d Add Principal to IDL (#1268)
71b3f980 Suppress inference for explicitly empty instantiations (#1265)
b9f7a808 Claudio/inference (#1242)
4a9cc844 Nix: Fetch ic-stub from ic-ref repo (#1243)
1ba12521 Basic upgrade infrastructure (#1199)
604f05e4 RTS: Track canister lifecycle state machine (#1231)
1b023617 Functorizes type pretty printing and hides stamps from IDE types (#1240)
31aa7aed Normalises file paths before sending them to the editors (#1237)
540bdeb0 Some more IDE fixes for the demo (#1236)
7a262e5b RTS: Put hash list of objects into static memory (#1233)
5dc2ad3c Some IDE robustness fixes (#1235)
2fd8bbb7 Separate diagnostics for beginning and end of scope (#1229)
97e4f2bd Completions and auto-imports for canisters (#1222)
0d827fe7 Improve error messages for scoped awaits (#1221)
95585009 Scans the passed package paths for .mo files (#1210)
3f9bb991 Backend: Implement eq on `Principal` (#1206)
ea327679 RTS: Fix utf8 validation bug (#1213)
05f41e1c Reports diagnostics at startup (#1215)
be2667f6 filters out completions that would lead to self-imports (#1214)
11ad5576 Bug fix in tabulateVar (#1207)
74dfa8cd Stdlib: add Nat/Int.min/max (#1205)
b81ba4bf Automatically import on completion (#1198)

nomeata · 2020-03-10T07:50:28Z

src/userlib/js/src/canisterId.ts

    return this._idHex;
  }
+  public toText(): string {
+    return 'ic:' + this.toHex() + '00';


Don’t forget a // TODO here :-)

eftychis · 2020-03-10T18:27:08Z

src/userlib/js/src/canisterId.ts

+      if (hex.length % 2 === 0 && /^[0-9A-F]+$/.test(hex)) {
+        // Remove the checksum from the hexadecimal.
+        // TODO: validate the checksum.
+        return this.fromHex(hex.slice(0, -2));


shouldn't fromHex fail here actually? (I thought it was failing.)

fromHex just stores the string. It doesn't do any checks.

I see. I can swear I had added checks in encode decode functions somewhere...

carry on 😉

eftychis · 2020-03-10T18:32:12Z

src/userlib/js/src/idl.ts

+      .toString('hex')
+      .toUpperCase();
+    // TODO implement checksum
+    return CanisterId.fromText('ic:' + hex + '00');


sounds good, but perhaps we need to centralize all this in a IC identifier library?? I am going to add senders for instance which is more of the same logic. And this is canister id specific. (No change asked for this PR, just asking, as I want to do something similar.)

Sure. Same applies to Rust. canisterId is defined inside the ic_http_agent crate. Probably separate that out as well.

Yes. I have been pondering that. Not sure which option is the best.

hansl

Blocking this for now while I investigate a problem with master.

eftychis · 2020-03-10T23:36:23Z

@hansl Any pointers as to what you are investigating?

hansl

Approving and merging this as it seems master is green (and so is this PR). I don't know why a bug with reply happened to some people (including the Node E2E PR).

feat(userlib): support reference types

2f03416

chenyan-dfinity changed the title ~~feat(userlib): support reference types~~ feat(userlib): Bump Motoko and support reference types Mar 6, 2020

chenyan-dfinity added 3 commits March 6, 2020 14:22

fix

90b3c67

fix

513e760

fix

0b723b9

chenyan-dfinity changed the title ~~feat(userlib): Bump Motoko and support reference types~~ feat(userlib): Bump Motoko and support principal type in userlib Mar 7, 2020

chenyan-dfinity and others added 2 commits March 8, 2020 20:40

Merge branch 'master' into idl-ref

098ac4d

refactor canisterId

1c364d3

nomeata reviewed Mar 10, 2020

View reviewed changes

bump motoko

eef4d6c

chenyan-dfinity marked this pull request as ready for review March 10, 2020 15:54

chenyan-dfinity requested a review from a team March 10, 2020 15:54

chenyan-dfinity requested a review from a team as a code owner March 10, 2020 15:54

eftychis reviewed Mar 10, 2020

View reviewed changes

eftychis approved these changes Mar 10, 2020

View reviewed changes

Merge branch 'master' into idl-ref

0e99523

hansl suggested changes Mar 10, 2020

View reviewed changes

hansl approved these changes Mar 11, 2020

View reviewed changes

hansl merged commit cda3ab5 into master Mar 11, 2020

chenyan-dfinity deleted the idl-ref branch March 11, 2020 17:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

feat(userlib): Bump Motoko and support principal type in userlib#433

feat(userlib): Bump Motoko and support principal type in userlib#433
hansl merged 8 commits intomasterfrom
idl-ref

chenyan-dfinity commented Mar 6, 2020 •

edited

Loading

Uh oh!

nomeata Mar 10, 2020

Uh oh!

eftychis Mar 10, 2020

Uh oh!

chenyan-dfinity Mar 10, 2020

Uh oh!

eftychis Mar 10, 2020 •

edited

Loading

Uh oh!

eftychis Mar 10, 2020

Uh oh!

chenyan-dfinity Mar 10, 2020

Uh oh!

eftychis Mar 10, 2020

Uh oh!

hansl left a comment

Uh oh!

eftychis commented Mar 10, 2020

Uh oh!

hansl left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

Conversation

chenyan-dfinity commented Mar 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nomeata Mar 10, 2020

Choose a reason for hiding this comment

Uh oh!

eftychis Mar 10, 2020

Choose a reason for hiding this comment

Uh oh!

chenyan-dfinity Mar 10, 2020

Choose a reason for hiding this comment

Uh oh!

eftychis Mar 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eftychis Mar 10, 2020

Choose a reason for hiding this comment

Uh oh!

chenyan-dfinity Mar 10, 2020

Choose a reason for hiding this comment

Uh oh!

eftychis Mar 10, 2020

Choose a reason for hiding this comment

Uh oh!

hansl left a comment

Choose a reason for hiding this comment

Uh oh!

eftychis commented Mar 10, 2020

Uh oh!

hansl left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chenyan-dfinity commented Mar 6, 2020 •

edited

Loading

eftychis Mar 10, 2020 •

edited

Loading